devFAIL

Here’s a JavaScript function, buried deep within a 5000+ line JavaScript file with absolutely no documentation, let alone variables that might indicate what the function’s use is.

function checkCheck(ct) {
        var v1;
        var v2 = false;
        var x;
        for(x = 1; x <= ct; x++) {
                v1 = $('check_' + x);
                if(v1) {
                        if(v1.checked == 1) {
                                return true;
                                break;
                        }
                        else {
                                continue;
                        }
                }
        }
        return v2;
}

Aside from the weirdness of the return/break/continue statements, v2 is never even used other than just to return false!

Posted on Tuesday, December 23rd, 2008 at 5:26 pm in FAIL | rss feed for comments| Leave a response, or trackback